Improve logging message for no shards found to indicate that export m… #3681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graytaylor0
requested review from
chenqi0805,
engechas,
dinujoh,
kkondaka,
asifsmohammed,
dlvenable and
oeyh
as code owners
…ay still be ongoing Signed-off-by: Taylor Gray <[email protected]>
graytaylor0
force-pushed
the
DdbLogging
branch
from
a03fc30 to
5da233d
Compare
dlvenable
previously approved these changes
Nov 16, 2023
Signed-off-by: Taylor Gray <[email protected]>
graytaylor0
force-pushed
the
DdbLogging
branch
from
d2122d4 to
6b7b209
Compare
engechas
approved these changes
Nov 16, 2023
dinujoh
approved these changes
Nov 16, 2023
| @@ -95,7 +95,7 @@ public void start(Buffer<Record<Event>> buffer) { | |||
| Runnable fileLoaderScheduler = new DataFileScheduler(coordinator, loaderFactory, pluginMetrics, acknowledgementSetManager, dynamoDBSourceConfig); | |||
|
|
|||
| ShardConsumerFactory consumerFactory = new ShardConsumerFactory(coordinator, dynamoDbStreamsClient, pluginMetrics, buffer); | |||
| Runnable streamScheduler = new StreamScheduler(coordinator, consumerFactory, pluginMetrics, acknowledgementSetManager, dynamoDBSourceConfig, new BackoffCalculator()); | |||
| Runnable streamScheduler = new StreamScheduler(coordinator, consumerFactory, pluginMetrics, acknowledgementSetManager, dynamoDBSourceConfig, new BackoffCalculator(dynamoDBSourceConfig.getTableConfigs().get(0).getExportConfig() != null)); | |||
There was a problem hiding this comment.
NPE is handled for dynamoDBSourceConfig.getTableConfigs().get(0) ?
There was a problem hiding this comment.
We validate it is exactly one here so should be fine yes? (
)
dlvenable
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ay still be ongoing
Description
Reduces the logging for no shards acquired to every 50 retries (approximately every 12 minutes) and only if there are no shards being processed at the time on the node, with an error message that indicates this may be due to either all shards being consumed already (by other nodes), or that an export is still in progress if export is configured.
This log makes it so that when no shards are available or the export is ongoing, we will not just see this as the final log
Which makes the node appear stuck and like it is not doing anything
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.